Skip to content

Conversation

@bwhaley
Copy link
Contributor

@bwhaley bwhaley commented Mar 4, 2021

Updated the reference architecture product page with the new diagram and copy. Also dropped references to GCP. Please review with an eye for typos! 👀

Hero and subhero content:
1

Updated diagram:
2

How it works:
3

More detail:
4

Now with hundreds of customers! (instead of 70):
5

New security features:
6

@netlify
Copy link

netlify bot commented Mar 4, 2021

Deploy preview for keen-clarke-470db9 ready!

Built with commit 8c08a69

https://deploy-preview-405--keen-clarke-470db9.netlify.app

josh-padnick
josh-padnick previously approved these changes Mar 4, 2021
Copy link
Contributor

@josh-padnick josh-padnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the lead on this! It's always the item I never get to. Left a few small comments, but otherwise this is ready to merge!

Co-authored-by: Josh Padnick <josh@gruntwork.io>
@bwhaley
Copy link
Contributor Author

bwhaley commented Mar 4, 2021

Thanks for the review! Just incorporated all the feedback. Please approve and we'll be good to ship it!

@josh-padnick
Copy link
Contributor

@eak12913 @oredavids @ebeneliason Could we get a rubber stamp on this? Regrettably, I've become a contributor and can't merge myself.

@yorinasub17
Copy link
Contributor

@josh-padnick if you hit approve, I believe we can still merge this, since the primary commit author for the suggestions is still Ben.

@josh-padnick
Copy link
Contributor

@yorinasub17 The issue is that I made suggestions which Ben accepted, making me a contributor. I know, I hate this!

@bwhaley
Copy link
Contributor Author

bwhaley commented Mar 4, 2021

What Yori is saying is that even though I accepted your suggestions and you became a committer, you can still approve by going to Files and Approve. After approving you should see the button turn green to merge. We confirmed this behavior on the service catalog and other repos.

@josh-padnick
Copy link
Contributor

Oh my gosh, I did not know this! What a revelation.

@ebeneliason @oredavids @eak12913 Note that code committers can still go to files / approve on PRs to approve them.

@josh-padnick josh-padnick merged commit 0e9173d into master Mar 5, 2021
@zackproser
Copy link
Contributor

@josh-padnick do we tend to leave branches around for the public website? If not, probably want to delete this.

@josh-padnick
Copy link
Contributor

Ah good call. Deleted now.

@josh-padnick josh-padnick deleted the update-ref-arch branch March 5, 2021 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants