fixed bug in calc_diff_abund_deseq2 #346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Great package! I found a bug in the
calc_diff_abund_deseq2that prevents the use of factors as grouping variables.It throws an error:
("M" is the name of my first factor here). I figured out it's because the
DESeq2::resultsfunction requires the names of the factors as arguments tocontrast, but instead the function is feeding it the factors directly. It seems to work fine if you just convert the grouping variable back to a character vector before feeding the combinations toDESeq2::resultorlfcShrink.