Skip to content

Conversation

@ethanbass
Copy link
Contributor

@ethanbass ethanbass commented Mar 25, 2023

Hi,
Great package! I found a bug in the calc_diff_abund_deseq2 that prevents the use of factors as grouping variables.

It throws an error:

Error in cleanContrast(object, contrast, expanded = isExpanded, listValues = listValues,  : 
  2 and 1 should be levels of group such that group_2_vs_M and group_1_vs_M are contained in 'resultsNames(object)'

("M" is the name of my first factor here). I figured out it's because the DESeq2::results function requires the names of the factors as arguments to contrast, but instead the function is feeding it the factors directly. It seems to work fine if you just convert the grouping variable back to a character vector before feeding the combinations to DESeq2::result or lfcShrink.

allows use of factors for grouping
@zachary-foster zachary-foster merged commit c2f488d into grunwaldlab:master Mar 28, 2023
@zachary-foster
Copy link
Contributor

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants