Fix Python 3 setup on non-UTF-8 systems #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup.py
Outdated
| @@ -1,10 +1,12 @@ | |||
| from setuptools import setup, find_packages | |||
| from io import open | |||
Owner
There was a problem hiding this comment.
I'd rather we didn't overwrite the open built-in, because I just find that confusing.
Owner
|
Do we not have the same issue with |
Contributor
Author
Ah, you're right. I missed that one. README.rst was just ASCII though so it didn't throw. |
gsnedders
added a commit
that referenced
this pull request
May 31, 2016
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pywas openingwebencodings/__init__.pyusing the system 8-bit encoding, so not UTF-8 on Windows. This change is compatible with Python 2.6 and 2.7.