Skip to content

Fix Python 3 setup on non-UTF-8 systems #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix Python 3 setup on non-UTF-8 systems #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1acdb5d
Open file to read version as UTF-8.
fkrull May 24, 2016
f4db4bf
Replace unnecessary non-ASCII characters.
fkrull May 24, 2016
09579c8
Use io.open explicitly.
fkrull May 25, 2016
6fb5d1c
Also specify encoding when opening README.rst.
fkrull May 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
from setuptools import setup, find_packages
import io
from os import path
import re


VERSION = re.search("VERSION = '([^']+)'", open(
path.join(path.dirname(__file__), 'webencodings', '__init__.py')
VERSION = re.search("VERSION = '([^']+)'", io.open(
path.join(path.dirname(__file__), 'webencodings', '__init__.py'),
encoding='utf-8'
).read().strip()).group(1)

LONG_DESCRIPTION = open(path.join(path.dirname(__file__), 'README.rst')).read()
LONG_DESCRIPTION = io.open(
path.join(path.dirname(__file__), 'README.rst'),
encoding='utf-8'
).read()


setup(
Expand Down
2 changes: 1 addition & 1 deletion webencodings/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def encode(input, encoding=UTF8, errors='strict'):

def iter_decode(input, fallback_encoding, errors='replace'):
"""
“Pull”-based decoder.
"Pull"-based decoder.

:param input:
An iterable of byte strings.
Expand Down