feat: Stream paginated list responses via iter_async#1885
Merged
Conversation
Generated list handlers eagerly collected the full result set with paged(ep, Pagination::All).query_async() before sending a single Action::ApiResponsesData, so the TUI table stayed empty until every page was fetched. Paged<E>::iter_async already exists for streaming consumption; wire generated list handlers to it instead, flushing the cumulative Vec every 50 items plus a final flush so table updates land incrementally without thrashing resort/scrollbar rebuild on every row. Also drops import/clone regressions introduced along the way: - api::QueryAsync only imported for non-paginated-list ops, since paginated list no longer calls .query_async() directly - serde_json::Value import dropped; generated code always fully-qualifies it, so the bare import was dead - eyre macro import now conditional on the file actually emitting an enum TryFrom<String> impl (the only call site) - set_request_data_from_input no longer clones Copy primitives (bool/int) under by_ref=True; dereferences like the non-by_ref path instead, fixing clippy::clone_on_copy - Display impl's `let mut parts` only gets `mut` when the struct actually has an id/name param pair to push, fixing an unused_mut warning on resources without one Changes are triggered by https://review.opendev.org/c/openstack/codegenerator/+/998610 Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated list handlers eagerly collected the full result set with
paged(ep, Pagination::All).query_async() before sending a single
Action::ApiResponsesData, so the TUI table stayed empty until every
page was fetched. Paged::iter_async already exists for streaming
consumption; wire generated list handlers to it instead, flushing
the cumulative Vec every 50 items plus a final flush so table
updates land incrementally without thrashing resort/scrollbar
rebuild on every row.
Also drops import/clone regressions introduced along the way:
paginated list no longer calls .query_async() directly
fully-qualifies it, so the bare import was dead
an enum TryFrom impl (the only call site)
(bool/int) under by_ref=True; dereferences like the non-by_ref
path instead, fixing clippy::clone_on_copy
let mut partsonly getsmutwhen the structactually has an id/name param pair to push, fixing an
unused_mut warning on resources without one
Changes are triggered by https://review.opendev.org/c/openstack/codegenerator/+/998610
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com