feat(tui): Dynamic Value+ColumnSpec items - #1914
Merged
Merged
Conversation
compute.flavor's `swap`, compute.hypervisor's `id`, and compute.server's `OS-EXT-SRV-ATTR:hostname` change type across microversions, so no single generated struct can represent every version. ResourceBehaviour::Item becomes a thin newtype around raw serde_json::Value for these plus image.image (converted to validate the pattern generalizes), reading table columns out of the response by JSON pointer instead. Column visibility, wide-only columns, and status-field row coloring are driven by ViewConfig (.config/config.yaml's `views.<resource>` entries), extended with `wide_fields` and `status_field` keys so this is configurable without recompiling, matching how `default_fields` already works. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compute.flavor's
swap, compute.hypervisor'sid, and compute.server'sOS-EXT-SRV-ATTR:hostnamechange type across microversions, so nosingle generated struct can represent every version.
ResourceBehaviour::Item becomes a thin newtype around raw
serde_json::Value for these plus image.image (converted to validate the
pattern generalizes), reading table columns out of the response by JSON
pointer instead.
Column visibility, wide-only columns, and status-field row coloring are
driven by ViewConfig (.config/config.yaml's
views.<resource>entries),extended with
wide_fieldsandstatus_fieldkeys so this isconfigurable without recompiling, matching how
default_fieldsalreadyworks.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com