fix(openapi): Safely handle schemas missing 'type' field - #1967
Merged
Conversation
Fixes a KeyError crash in _find_schema_property when traversing schemas that use 'oneOf' without an explicit 'type' (e.g. server list/detail response schemas). The bare except block silently swallowed this crash, causing api-ref description merging to fail for affected operations and producing non-deterministic YAML output due to Python hash-seed dependent schema ordering. Changes are triggered by https://review.opendev.org/c/openstack/codegenerator/+/1000983 Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a KeyError crash in _find_schema_property when traversing
schemas that use 'oneOf' without an explicit 'type' (e.g. server
list/detail response schemas). The bare except block silently
swallowed this crash, causing api-ref description merging to fail
for affected operations and producing non-deterministic YAML output
due to Python hash-seed dependent schema ordering.
Changes are triggered by https://review.opendev.org/c/openstack/codegenerator/+/1000983
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com