fix(rust-types): render nullable arrays as Option - #1970
Merged
Conversation
gtema
force-pushed
the
codegenerator_1003297
branch
from
September 2, 2026 11:15
7328eda to
7077443
Compare
Fields declared as `required` with a type list that includes 'null' (e.g. `type: [array, null]`) were rendered as plain types because the field's is_nullable flag was not taken into account when computing the Rust type hint. The oneOf conversion already moved the Option wrapper into is_nullable (and additionally unwrapped the Array for nullable arrays), but StructFieldResponse.type_hint only wrapped based on is_optional. Required nullable arrays therefore became `Vec<T>` and failed to deserialize responses where the API legitimately returns null (e.g. `trusted_image_certificates`, `hosts`, `fixed_ips`), silently degrading CLI tables to the minimal fallback schema. Emit `Option<T>` for nullable fields as well, and mark them as structable `optional` so `None` values render as empty cells instead of the string "null". Changes are triggered by https://review.opendev.org/c/openstack/codegenerator/+/1003297 Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
gtema
force-pushed
the
codegenerator_1003297
branch
from
September 2, 2026 11:16
7077443 to
d27f9b4
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fields declared as
requiredwith a type list that includes 'null'(e.g.
type: [array, null]) were rendered as plain types because thefield's is_nullable flag was not taken into account when computing the
Rust type hint.
The oneOf conversion already moved the Option wrapper into is_nullable
(and additionally unwrapped the Array for nullable arrays), but
StructFieldResponse.type_hint only wrapped based on is_optional.
Required nullable arrays therefore became
Vec<T>and failed todeserialize responses where the API legitimately returns null (e.g.
trusted_image_certificates,hosts,fixed_ips), silently degradingCLI tables to the minimal fallback schema.
Emit
Option<T>for nullable fields as well, and mark them asstructable
optionalsoNonevalues render as empty cells instead ofthe string "null".
Changes are triggered by https://review.opendev.org/c/openstack/codegenerator/+/1003297
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com