refactor(tui): Forward block_storage to gen ResourceBehaviour - #1977
Merged
Conversation
PR #1975 added the generated mechanical tier for the block_storage resources. Thin the hand-written `ResourceBehaviour` impls to one-line forwarders onto `super::generated::<r>::Generated::<method>`, keeping only custom logic: - `volumes.rs`: `confirm_request` delete prompt plus its `TryFrom<&serde_json::Value>` for the delete request builder. - `backups.rs` / `snapshots.rs`: pure forwarders; their `view_key()` now resolves through `crate::mode::BLOCK_STORAGE_*` via the companion instead of a bare string literal. All three resources use the `list_detailed` operation, so the generated tier resolves the `ListDetailed` request variant, matching the prior hand code. Assisted-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
gtema
force-pushed
the
tui-thin-block-storage
branch
from
September 3, 2026 16:16
8bfc33d to
9f8aaa1
Compare
gtema
enabled auto-merge (squash)
September 3, 2026 16:16
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1975 added the generated mechanical tier for the block_storage
resources. Thin the hand-written
ResourceBehaviourimpls to one-lineforwarders onto
super::generated::<r>::Generated::<method>, keepingonly custom logic:
volumes.rs:confirm_requestdelete prompt plus itsTryFrom<&serde_json::Value>for the delete request builder.backups.rs/snapshots.rs: pure forwarders; theirview_key()now resolves through
crate::mode::BLOCK_STORAGE_*via the companioninstead of a bare string literal.
All three resources use the
list_detailedoperation, so the generatedtier resolves the
ListDetailedrequest variant, matching the priorhand code.
Assisted-By: Claude Sonnet 5 noreply@anthropic.com
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com