Skip to content

Add tags to atoms#211

Merged
waisingyiu merged 1 commit into
mainfrom
ws/add-tag-to-atom
May 6, 2026
Merged

Add tags to atoms#211
waisingyiu merged 1 commit into
mainfrom
ws/add-tag-to-atom

Conversation

@waisingyiu
Copy link
Copy Markdown
Contributor

@waisingyiu waisingyiu commented Apr 29, 2026

This pull request adds a new property for a list of tag IDs to atoms as part of our work on making atoms taggable. The motivation is to improve data analysis using tracking data from data lake by splitting data based on the tags associated with the atom.

For this purpose, we just need the tag IDs on the atom. To avoid increasing the complexity of the work unnecessarily (particularly as this thrift model is shared between the tools and the CAPI Concierge), we simply add a list of tag IDs as strings to the atom model.


@waisingyiu waisingyiu changed the title Add tags to atom model Add tags to atoms Apr 29, 2026
@waisingyiu waisingyiu marked this pull request as ready for review April 29, 2026 16:09
@waisingyiu waisingyiu requested review from a team as code owners April 29, 2026 16:09
@waisingyiu waisingyiu requested a review from SHession April 29, 2026 16:09
Copy link
Copy Markdown
Contributor

@SHession SHession left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, it would be good to update the description with our revised approach for prosperity.

@waisingyiu
Copy link
Copy Markdown
Contributor Author

Code changes look good, it would be good to update the description with our revised approach for prosperity.

Thanks @SHession . I've updated the description. Great if you can take another look to see if it's accurate.

gu-scala-library-release Bot added a commit that referenced this pull request Apr 30, 2026
…by waisingyiu

waisingyiu published release version 11.0.0-PREVIEW.wsadd-tag-to-atom.2026-04-30T1425.deb1ffbf
using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow

Release-Version: 11.0.0-PREVIEW.wsadd-tag-to-atom.2026-04-30T1425.deb1ffbf
Release-Initiated-By: https://github.com/waisingyiu
Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/25170902764
Release-Notes: #211
@gu-scala-library-release
Copy link
Copy Markdown
Contributor

@waisingyiu has published a preview version of this PR with release workflow run #49, based on commit deb1ffb:

11.0.0-PREVIEW.wsadd-tag-to-atom.2026-04-30T1425.deb1ffbf

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the ws/add-tag-to-atom branch, or use the GitHub CLI command:

gh workflow run release.yml --ref ws/add-tag-to-atom

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

Copy link
Copy Markdown
Member

@davidfurey davidfurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants