Add video tracking subtype#648
Merged
Merged
Conversation
SHession
reviewed
May 18, 2026
| {name: 'Platform Functional', value: 'platformfunctional'}, | ||
| {name: 'Audience', value: 'audience'} | ||
| {name: 'Audience', value: 'audience'}, | ||
| {name: 'Video', value: 'video'}, |
Contributor
There was a problem hiding this comment.
AFAICT It doesn't look like this data is included in the Tag Thrift definition. Is this the only place where the sub type is specified?
Contributor
Author
There was a problem hiding this comment.
Yes, I think so. The subtype is represented as a plain string in the Tag Thrift model - https://github.com/guardian/tags-thrift-schema/blob/main/src/main/thrift/tag.thrift#L129
SHession
approved these changes
May 18, 2026
|
Seen on PROD (merged by @waisingyiu 4 minutes and 26 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
We are working on making content atoms taggable to improve data analysis.
The pull request adds a subtype
videoundertrackingtype for tags that will be intended for video tracking.How has this change been tested?
In tagmanager, create a new tag and on the UI we should be able to select the new subtype
videounder thetrackingtype. After creating a tag with video tracking subtype, we could find the tags by the API - e.g. https://tagmanager.code.dev-gutools.co.uk/hyper/tags?query=&type=tracking&subType=video&limit=150Images