Propagate pgUp and pgDown when caret in searchbox#4544
Merged
andrew-nowak merged 1 commit intomainfrom Oct 17, 2025
Merged
Conversation
andrew-nowak
approved these changes
Oct 17, 2025
gu-prout
Bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-auth
Seen-on-leases
Seen-on-usage
Seen-on-kahuna
Seen-on-image-loader
and removed
Pending-on-cropper
Pending-on-leases
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
labels
|
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, kahuna (created by @paperboyo and merged by @andrew-nowak 9 minutes and 41 seconds ago) Please check your changes! |
|
Seen on media-api (created by @paperboyo and merged by @andrew-nowak 9 minutes and 47 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Grid usefully scrolls results in steps when using up/down and pgUp/pgDown keys. This PR adds latter keys to CQL config, so that steps work also when caret is in the searchbox.
How should a reviewer test this change?
Turn CQL feature switch, put caret in searchbox and try pgUp/pgDown, observe results advancing in full-page steps.
@guardian/newsroom-resilience
Tested? Documented?