Skip to content

For embedder access to image bucket, use grantRead and scope to test/prod#4653

Merged
joelochlann merged 3 commits intomainfrom
js-use-grant-read-for-s3-access
Mar 9, 2026
Merged

For embedder access to image bucket, use grantRead and scope to test/prod#4653
joelochlann merged 3 commits intomainfrom
js-use-grant-read-for-s3-access

Conversation

@joelochlann
Copy link
Copy Markdown
Member

@joelochlann joelochlann commented Mar 4, 2026

Benefits:

  • easier to read
  • doesn't grant the TEST lambda access to PROD
  • gives List permissions which should mean we don't get spurious errors when objects don't exist (see AWS docs). We've only ever seen this twice in production (not quite sure why?) but still good to fix

testing

  • check on TEST

@joelochlann joelochlann added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Mar 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2026

@joelochlann joelochlann marked this pull request as ready for review March 4, 2026 16:06
@joelochlann joelochlann requested a review from a team as a code owner March 4, 2026 16:06
@joelochlann joelochlann changed the title Use grantRead and scope to test/prod For embedder access to image bucket, use grantRead and scope to test/prod Mar 4, 2026
@joelochlann joelochlann changed the title For embedder access to image bucket, use grantRead and scope to test/prod For embedder access to image bucket, use grantRead and scope to test/prod Mar 4, 2026
@joelochlann joelochlann requested a review from ellenmuller March 6, 2026 17:51
@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented Mar 9, 2026

Seen on cropper (merged by @joelochlann 9 minutes and 50 seconds ago) Please check your changes!

@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented Mar 9, 2026

Seen on metadata-editor, image-loader, kahuna, media-api (merged by @joelochlann 9 minutes and 56 seconds ago) Please check your changes!

@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented Mar 9, 2026

Seen on auth, thrall, usage (merged by @joelochlann 10 minutes and 2 seconds ago) Please check your changes!

@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented Mar 9, 2026

Seen on collections, leases (merged by @joelochlann 10 minutes and 9 seconds ago) Please check your changes!

1 similar comment
@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented Mar 9, 2026

Seen on collections, leases (merged by @joelochlann 10 minutes and 9 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants