define client each handler invocation#4662
Merged
Merged
Conversation
joelochlann
approved these changes
Mar 11, 2026
Member
joelochlann
left a comment
There was a problem hiding this comment.
Nice! Thanks for actioning so quickly.
Only thing we might want to add is some timing logging around the client init, so we know how much it costs us in latency to re-init on every invocation. Could be useful for pressuring AWS to fix their dodgy SDK!
|
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @ellenmuller 9 minutes and 46 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Yesterday in the AWS office hour, we were told that the bedrock Client TCP connection is probably timing out after it is waiting for a response for bedrock for a long time. If true, this will exacerbate our backfill issues because it means that once we encounter the first hanging bedrock request, subsequent requests will always time out too because of the issue with the client.
Re-initialising the client each handler invocation won't fix the issues Bedrock server-side, but this might for now make our DLQ re-drive run more smoothly. It's worth a try!
See - https://aws.amazon.com/blogs/networking-and-content-delivery/implementing-long-running-tcp-connections-within-vpc-networking/