This repository was archived by the owner on Jun 15, 2021. It is now read-only.
Merged
Conversation
Contributor
|
As long as it works in all versions of FF and Chrome! 👍 Would be great to add a test for this as discussed, as well as an addition to the BROWSERINCONSISTENCIES file if applicable. |
Contributor
Author
|
Sure. Will add those next... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously patching a Firefox bug to place the selection in the correct place. It turns Chrome >= 38 now has the same behaviour as Firefox so we should always do the patch.
NOTE: That this is just a quickfix (or hotfix @robinedman). Once this has been merged and released I will update the tests and the browser inconsistencies.
\cc @theefer @sihil @robinedman