You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixed
React Native under the New Architecture: a settled morph no longer resets to the icon the component mounted with (#25, reported by @PhilipGrefe). On Fabric every commit rebuilds the native path from the props React declares, so the d the binding froze at mount overwrote whatever the driver had written through setNativeProps. Any later render that did not touch the icon, a color or selection change in a tab strip in the report's case, restored the initial path. Four states were affected rather than the reported one: at rest, mid-flight, after a lazy imperative birth (where the path went back to empty and the icon disappeared) and mid-scrub in controlled mode. The binding now declares the driver's live d on every render and re-applies it in a layout effect when a frame landed between a render and its commit, with no state update per frame. Those effects are real layout effects on a device now: the runtime probe is window, because React Native has no document and probing for it demoted both the driver's birth and the repair to passive effects that run after paint. The initial d is still computed once with the pure core, so react-native-web SSR output does not move, and the core, the driver, the adapters and the other four bindings are byte identical to 1.7.0.