Replace chalk #134
Replace chalk #134
Conversation
test/shared/stripAnsi.js
Outdated
| ].join('|'); | ||
| var ansiRegex = new RegExp(ansiPattern, 'g'); | ||
|
|
||
| function stripAnsi(value) { |
There was a problem hiding this comment.
Maybe it would be better to move this to gulp-test-tools if possible?
There was a problem hiding this comment.
@tdeschryver I also think it's good and welcome to send a pr to gulp-test-tools.
There was a problem hiding this comment.
OK, I'll try to open a PR later today!
There was a problem hiding this comment.
Or even better, I think we should use strip-color.
If thats OK.
|
Does |
|
@sttk it does has a ansi-reset and it also has a ansi-wrap. |
|
@tdeschryver |
|
Looks like this still needs to support |
|
Oops, totally forgot about this 😅, I'll add during this week! |
|
Thanks! I'm guessing you won't need the |
|
Hmmm weird, seems like those fixtures which were added got changed from |
|
@tdeschryver https://github.com/doowb/ansi-colors now inlines all the colors. This will likely be the best solution for us. I can look into making those changes if you don't have time. |
|
@phated I'm currently a bit busy, if you need it right now it would be best if someone else takes this. |
|
Closed by #138 |
3 participants
Closes #125