feat(form-assistant): wire Settings toggle and extend to all connectors #279
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -81,6 +81,7 @@ export class SettingsPageController { | |
| private readonly shippedConnectorCatalog: readonly ConnectorMeta[]; | ||
| private readonly resetAvailability: LocalDataResetRuntimeAvailability; | ||
| private readonly unsubscribeProfileMessages = this.subscribeProfileMessages(); | ||
| private readonly unsubscribeFormAssistMessages = this.subscribeFormAssistMessages(); | ||
| private readonly unsubscribeSettingsSnapshots: () => void; | ||
|
|
||
| private readonly profileActor = createProfileStore({ | ||
|
|
@@ -127,6 +128,14 @@ export class SettingsPageController { | |
| connectedPendingDownloads = $state(0); | ||
| connectedSyncError = $state<string | null>(null); | ||
|
|
||
| /** | ||
| * Form Assistant activation (Machine D — src/models/form-assistant.model.md). | ||
| * Miroir de l'état persisté dans le SW (chrome.storage.local). Le toggle ne | ||
| * écrit JAMAIS directement en storage : il émet FORM_ASSIST_ENABLE via bridge. | ||
| */ | ||
| formAssistEnabled = $state(false); | ||
| formAssistStatus = $state<'loading' | 'ready' | 'error'>('loading'); | ||
|
|
||
| showResetConfirm = $state(false); | ||
| resetError = $state<string | null>(null); | ||
|
|
||
|
|
@@ -173,8 +182,26 @@ export class SettingsPageController { | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * Racolement Machine D : le SW diffuse FORM_ASSIST_ENABLED après toute | ||
| * mutation persistée. Le panel est un miroir, jamais la source primaire. | ||
| */ | ||
| private subscribeFormAssistMessages(): () => void { | ||
| try { | ||
| return subscribeMessages((message) => { | ||
| if (message.type === 'FORM_ASSIST_ENABLED') { | ||
| this.formAssistEnabled = Boolean(message.payload.enabled); | ||
| this.formAssistStatus = 'ready'; | ||
| } | ||
| }); | ||
| } catch { | ||
| return () => {}; | ||
| } | ||
| } | ||
|
|
||
| destroy(): void { | ||
| this.unsubscribeProfileMessages(); | ||
| this.unsubscribeFormAssistMessages(); | ||
| this.unsubscribeSettingsSnapshots(); | ||
| } | ||
|
|
||
|
|
@@ -201,6 +228,7 @@ export class SettingsPageController { | |
| this.loadSettings(), | ||
| this.loadConnectedAccount(), | ||
| this.loadScanHistory(), | ||
| this.loadFormAssist(), | ||
| ]); | ||
| } | ||
|
|
||
|
|
@@ -237,6 +265,51 @@ export class SettingsPageController { | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * Lit l'état persisté du Form Assistant auprès du SW (Machine D — INIT). | ||
| * Échec (SW injoignable) → état `error` mais la page reste utilisable. | ||
| */ | ||
| async loadFormAssist(): Promise<void> { | ||
| this.formAssistStatus = 'loading'; | ||
| try { | ||
| const result = (await sendMessage({ type: 'FORM_ASSIST_STATUS' })) as | ||
| { type: 'FORM_ASSIST_STATUS_RESULT'; payload: { enabled: boolean } } | undefined; | ||
| this.formAssistEnabled = Boolean(result?.payload.enabled); | ||
| this.formAssistStatus = 'ready'; | ||
| } catch { | ||
| this.formAssistStatus = 'error'; | ||
| } | ||
| } | ||
|
Comment on lines
+272
to
+282
|
||
|
|
||
| /** | ||
| * Bascule l'activation du Form Assistant. Le SW persiste et diffuse | ||
| * FORM_ASSIST_ENABLED (racolement). L'UI reste optimiste : on met à jour | ||
| * immédiatement pour la réactivité, et le message SW confirme/rétablit. | ||
| */ | ||
| async toggleFormAssist(): Promise<void> { | ||
| if (this.formAssistStatus === 'loading') { | ||
| return; | ||
| } | ||
| const next = !this.formAssistEnabled; | ||
| const previous = this.formAssistEnabled; | ||
| this.formAssistEnabled = next; | ||
| this.formAssistStatus = 'loading'; | ||
| try { | ||
| const result = (await sendMessage({ | ||
| type: 'FORM_ASSIST_ENABLE', | ||
| payload: { enabled: next }, | ||
| })) as { type: 'FORM_ASSIST_ENABLED'; payload: { enabled: boolean } } | undefined; | ||
| // La réponse du SW est la source de vérité (elle peut différer de | ||
| // l'optimisme en cas d'erreur persistée côté SW). | ||
| this.formAssistEnabled = Boolean(result?.payload.enabled); | ||
| this.formAssistStatus = 'ready'; | ||
|
Comment on lines
+304
to
+305
There was a problem hiding this comment.
When a user disables an enabled assistant and AGENTS.md reference: AGENTS.md:L89-L94 Useful? React with 👍 / 👎. |
||
| } catch { | ||
| this.formAssistEnabled = previous; | ||
| this.formAssistStatus = 'error'; | ||
| await showToast("Impossible d'activer l'assistant de candidature", 'error'); | ||
| } | ||
| } | ||
|
Comment on lines
+289
to
+311
|
||
|
|
||
| async loadSettings(): Promise<void> { | ||
| try { | ||
| const settings = await getSettings(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For every newly opted-in connector, this flag injects the assistant across the connector's entire host pattern, but
content/form-assistant/field-detector.ts:110-132accepts every writable text-like input and the classifier maps unmatched or unlabeled fields tofree-text. The widget will therefore arm on login email boxes, global search bars, chat inputs, and other non-application fields throughout LeHibou and the other newly enabled sites, contrary to the application-form scope described byform-assistant.model.md. Add an application-context or eligible-field guard before enabling these whole origins.Useful? React with 👍 / 👎.