feat(harness): add Lint() diagnostic method (ADR-0045 Phase 3 PR 1) - #23
Closed
guyoron1 wants to merge 11 commits into
Closed
feat(harness): add Lint() diagnostic method (ADR-0045 Phase 3 PR 1)#23guyoron1 wants to merge 11 commits into
guyoron1 wants to merge 11 commits into
Conversation
…nings (ADR-0045 Phase 3 PR 1) Add a Lint() method to the Harness struct that returns non-fatal diagnostics separate from Validate(). The first rule warns when the role field is missing, preparing for Phase 4 which will make it required. Also adds the Phase 3 implementation plan. Signed-off-by: Greg Allen <gallen@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
Owner
Author
|
/fs-qf |
Go tier 1: 0 files → qf-tests/ADR-0045/go/ Python tier 2: 0 files → qf-tests/ADR-0045/python/ [skip ci]
QualityFlow Pipeline Summary
Test Output
Issue: GH-23 Generated by QualityFlow |
Owner
Author
|
/fs-qf |
5 similar comments
Owner
Author
|
/fs-qf |
Owner
Author
|
/fs-qf |
Owner
Author
|
/fs-qf |
Owner
Author
|
/fs-qf |
Owner
Author
|
/fs-qf |
Owner
Author
|
/qf |
1 similar comment
Owner
Author
|
/qf |
Verdict: NEEDS_REVISION (7 critical, 5 major, 1 minor) The STP was generated for the wrong feature and must be regenerated. Co-Authored-By: QualityFlow <qualityflow[bot]@users.noreply.github.com>
…te fields [skip ci] Co-Authored-By: QualityFlow <qualityflow[bot]@users.noreply.github.com>
Owner
Author
|
Closing — QualityFlow test artifacts were inadvertently pushed to this branch. Will re-test on dedicated PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fullsend-ai#2326
Summary
Lint()method to theHarnessstruct returning[]Diagnostic— non-fatal warnings separate fromValidate()(which returns hard errors)rolefield is missing, preparing for Phase 4 which will make it requireddocs/plans/adr-0045-forge-portable-harness-phase3.md)Details
New files:
internal/harness/lint.go—DiagnosticSeveritytype,Diagnosticstruct withString(), andHarness.Lint()methodinternal/harness/lint_test.go— 6 subtests covering role presence/absence, severity formatting, and unknown severity fallbackNo existing files modified.
Validate()is unchanged. No callers ofLint()are added yet — that is Phase 3 PR 3.100% code coverage on
lint.go. All existing tests pass.Test plan
go test -v -run TestLint ./internal/harness/— all 6 subtests passgo test -coverprofile=cover.out ./internal/harness/ && go tool cover -func=cover.out | grep lint.go— 100% coverage on lint.gomake go-test— all existing tests passmake lint— passesmake go-vet— passes🤖 Generated with Claude Code