feat: optional terminal mouse taps, off by default#131
Merged
Conversation
Keep always-show-keyboard on tap, but stop injecting mouse reports unless the user opts in under Appearance → Terminal.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the soft-keyboard fix for mouse-aware TUIs, tapping the terminal always opens the keyboard even when mouse tracking is on. That is what we want, but the tap is still forwarded as a mouse report (SGR, e.g.
0;col;rowM/0;col;rowm).When the remote side is a plain shell, or mouse tracking was left on after a TUI exited, those reports show up as garbage on the command line. Coordinates change with every tap, so it looks random.
Approach
Keep the always-show-keyboard behavior. Make sending mouse taps optional.
Persisted with the other appearance prefs, included in backup/restore. Uses conduit_vt's existing
PointerInputs/TerminalController.setPointerInputsso we only gate tap reporting; keyboard focus callbacks are unchanged.Changes
lib/core/theme/theme_preferences_repository.dart— storeterminalMouseInput(default false)lib/core/theme/theme_controller.dart— load/save/togglelib/core/presentation/theme_sheet.dart— Appearance UIlib/features/terminal/presentation/widgets/terminal_surface.dart— wire pointer inputslib/features/terminal/presentation/terminal_page.dart— pass preference into the surfacelib/features/backup/data/app_backup_service.dart— backup fieldTesting