Reset reader position after retrieving signature bytes #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
When using this library, we saw some unexpected behavior when using this library in-line with file uploads. We were passing the file pointer to
filetype.guessdirectly, and then our handler would proceed to upload the file using the same file pointer. Since the pointer is not reset afterfiletype.guessruns, we were seeing truncated files. Wanted to raise this potential usage issue and offer this patch as a suggestion.Otherwise, we've found this library to be super useful and easy to use, many thanks for your work on it.