fix(#51): reset the cursor position of stream #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosas
reviewed
Dec 23, 2020
filetype/utils.py
Outdated
| """ | ||
| try: | ||
| obj = obj.read(_NUM_SIGNATURE_BYTES) | ||
| if type(obj) is IOBase: |
There was a problem hiding this comment.
@salehdeh76 Could you use if isinstance(obj, IOBase)
…nd transparent to users
SalehDehqanpour
force-pushed
the
master
branch
from
124134b to
15d2bd5
Compare
Author
|
@dosas I fixed it. Please review it again. Thanks |
|
@salehdeh76 Did you see this PR https://github.com/h2non/filetype.py/pull/51/files ? There is already an open question? Also, a unit test is always a plus :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(#51): reset the cursor position of stream so be idempotent and transparent to users