[Bugfix] Whitelist remove / scan response timer crash on invalid pointers

[h2zero]

Summary by CodeRabbit

• Bug Fixes
  • Improved Bluetooth whitelist updates and removals for more reliable device management.
  • Improved scan shutdown and cleanup during host deinitialization.
  • Deferred scan-response timer setup until needed, reducing unnecessary resource usage.
  • Ensured pending scan devices and timers are safely cleared when scanning ends.
  • Prevented scan timeouts when timer setup fails.
  • Added clearer failure reporting when Bluetooth host shutdown cannot complete.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cb6c0f32-bd11-4b31-a3d6-ad3cef53ad26

📥 Commits

Reviewing files that changed from the base of the PR and between 2fbcebe and ef100d6.

📒 Files selected for processing (3)

• src/NimBLEDevice.cpp
• src/NimBLEScan.cpp
• src/NimBLEScan.h

🚧 Files skipped from review as they are similar to previous changes (3)

• src/NimBLEDevice.cpp
• src/NimBLEScan.h
• src/NimBLEScan.cpp

---

📝 Walkthrough

Walkthrough

The PR updates whitelist synchronization and removal handling. It adds lazy scan-response timer initialization, guarded cleanup, host-deinitialization handling, and failure reporting for nimble_port_stop(), arr.

Changes

Scan and whitelist lifecycle

Layer / File(s)	Summary
Whitelist synchronization fixes src/NimBLEDevice.cpp	Whitelist updates use m_whiteList.data(). Removal stops after the successful erase and buffer swap.
Scan-response timer lifecycle src/NimBLEScan.h, src/NimBLEScan.cpp, src/NimBLEDevice.cpp	The callout initializes only when pending devices require a timer. Stop and deinitialization paths check the initialization flag. Host deinitialization clears pending devices and deinitializes the callout before host teardown.
Host stop failure handling src/NimBLEDevice.cpp	deinit logs a nimble_port_stop() failure and returns false when the stop operation fails, arrr.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant NimBLEDevice
  participant NimBLEScan
  participant ScanResponseCallout
  participant NimBLEHost
  NimBLEDevice->>NimBLEScan: onHostDeinit()
  NimBLEScan->>NimBLEScan: clearWaitingList()
  NimBLEScan->>ScanResponseCallout: deinit()
  NimBLEDevice->>NimBLEHost: stop and deinitialize
  NimBLEDevice->>NimBLEDevice: log and return false if nimble_port_stop() fails

Loading

Possibly related PRs

• h2zero/esp-nimble-cpp#410: This PR refines the scan-response timer and waiting-list lifecycle introduced by PR #410, arr.

Poem

Arr, the whitelist finds its proper data berth.
The scan timer wakes only when devices need its worth.
Pending entries clear before hosts depart.
Failed stops now report their part.
Safe callouts guard the chart.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the whitelist removal and scan-response timer crash fixes described in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bugfix/wl

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/NimBLEScan.cpp`:
- Around line 699-702: Move the NimBLE scan host-deinitialization call from its
current pre-stop location into the successful `rc == 0` shutdown path,
immediately after `nimble_port_stop()` and before `nimble_port_deinit()`. Update
the flow around `NimBLEDevice::m_pScan->onHostDeinit()` so
`ble_npl_callout_deinit()` in `onHostDeinit()` cannot run while NimBLE task
callbacks remain queued.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c44d8930-28ae-459e-b3bc-1913c24e4c79

📥 Commits

Reviewing files that changed from the base of the PR and between 3413bf9 and 2fbcebe.

📒 Files selected for processing (3)

• src/NimBLEDevice.cpp
• src/NimBLEScan.cpp
• src/NimBLEScan.h