Skip to content

fix(cli): avoid login shells for lifecycle commands#40

Merged
roodboi merged 1 commit into
mainfrom
dimitri/fix-lifecycle-non-login-shell
Apr 1, 2026
Merged

fix(cli): avoid login shells for lifecycle commands#40
roodboi merged 1 commit into
mainfrom
dimitri/fix-lifecycle-non-login-shell

Conversation

@roodboi

@roodboi roodboi commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • run lifecycle commands with sh -c instead of login-shell mode
  • keep the process-group cleanup wrapper intact while avoiding ~/.profile startup dependencies
  • add regression coverage for the non-login lifecycle launcher contract

Verification

  • bun test tests/project-lifecycle-processes.test.ts
  • bun run typecheck
  • bun x ultracite check src/commands/project.ts tests/project-lifecycle-processes.test.ts

@changeset-bot

changeset-bot Bot commented Apr 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2963d46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@roodboi
roodboi merged commit 8a21daf into main Apr 1, 2026
3 checks passed
@roodboi
roodboi deleted the dimitri/fix-lifecycle-non-login-shell branch April 1, 2026 17:16
roodboi pushed a commit that referenced this pull request Apr 1, 2026
## <small>2.2.1 (2026-04-01)</small>

* Merge pull request #40 from hack-dance/dimitri/fix-lifecycle-non-login-shell ([8a21daf](8a21daf)), closes [#40](#40)
* fix(cli): avoid login shells for lifecycle commands ([2963d46](2963d46))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant