Skip to content

fix(release): install Homebrew executable path#62

Merged
roodboi merged 1 commit into
mainfrom
codex/homebrew-bin-link-repair
Jul 9, 2026
Merged

fix(release): install Homebrew executable path#62
roodboi merged 1 commit into
mainfrom
codex/homebrew-bin-link-repair

Conversation

@roodboi

@roodboi roodboi commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • write the Homebrew launcher to bin/hack instead of replacing the formula prefix's bin directory with a file
  • make the formula renderer import-safe and directly test its generated install contract

Production evidence

The canonical v3.3.3 formula downloaded and installed successfully, but produced:

/opt/homebrew/Cellar/hack/3.3.3/bin: Bourne-Again shell script text executable

Because bin itself was a file, Homebrew linked no /opt/homebrew/bin/hack, and the formula's own #{bin}/hack --help test path could not exist. The generator emitted bin.write_env_script; Homebrew requires (bin/"hack").write_env_script.

Verification

  • bun test tests/update-homebrew-tap.test.ts — 1 passed
  • bunx ultracite check scripts/update-homebrew-tap.ts tests/update-homebrew-tap.test.ts — passed
  • bun run --cwd packages/cli typecheck — passed
  • real renderer invocation against release v3.3.3 produced Formula/hack.rb with (bin/"hack").write_env_script and the existing #{bin}/hack --help formula test

Compatibility and release signal

  • release tarball layout and CLI behavior are unchanged
  • only the generated Homebrew installation path changes
  • this is a production packaging fix and should trigger the next patch release so the release workflow republishes the corrected formula

@roodboi

roodboi commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 3c6e0d95bf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@roodboi roodboi merged commit 30841be into main Jul 9, 2026
4 checks passed
@roodboi roodboi deleted the codex/homebrew-bin-link-repair branch July 9, 2026 20:54
roodboi pushed a commit that referenced this pull request Jul 9, 2026
## <small>3.3.4 (2026-07-09)</small>

* Merge pull request #62 from hack-dance/codex/homebrew-bin-link-repair ([30841be](30841be)), closes [#62](#62)
* fix(release): install Homebrew executable path ([3c6e0d9](3c6e0d9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant