fix(release): install Homebrew executable path#62
Merged
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
roodboi
pushed a commit
that referenced
this pull request
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/hackinstead of replacing the formula prefix'sbindirectory with a fileProduction evidence
The canonical
v3.3.3formula downloaded and installed successfully, but produced:Because
binitself was a file, Homebrew linked no/opt/homebrew/bin/hack, and the formula's own#{bin}/hack --helptest path could not exist. The generator emittedbin.write_env_script; Homebrew requires(bin/"hack").write_env_script.Verification
bun test tests/update-homebrew-tap.test.ts— 1 passedbunx ultracite check scripts/update-homebrew-tap.ts tests/update-homebrew-tap.test.ts— passedbun run --cwd packages/cli typecheck— passedv3.3.3producedFormula/hack.rbwith(bin/"hack").write_env_scriptand the existing#{bin}/hack --helpformula testCompatibility and release signal