Conversation
Signed-off-by: Rick Mark <rickmark@outlook.com>
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates PKI OID metadata and aligns the schema spec with the updated OID “name” values, while also expanding IMG4 YAML metadata.
Changes:
- Renames the OID “name” for
1.2.840.113635.100.6.1.15and updates the corresponding RSpec expectation. - Adds several new OID entries/fields in
_data/pki.yaml. - Removes placeholder keys and adds/adjusts tag/property metadata in
_data/img4.yaml.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| spec/apple_data/schemas/pki_spec.rb | Updates the expected string form for an OID entry to match renamed YAML data. |
| _data/pki.yaml | Renames one OID “name” and introduces additional OID records/fields. |
| _data/img4.yaml | Cleans up placeholder properties and adds additional IMG4 tag/property titles/descriptions. |
Files not reviewed (2)
- .idea/apple-knowledge.iml: Generated file
- .idea/runConfigurations/AppleData_Specs.xml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 1.2.840.113635.100.6.1.15: | ||
| title: IMG4 Manifest Certificate Specification | ||
| name: appleImg4Manifest | ||
| name: appleImg4ManifestSpecification |
Comment on lines
+146
to
+147
| 1.2.840.113635.100.6.8: | ||
| name: appleImg4Manifest |
Comment on lines
+266
to
+267
| 1.2.840.113635.100.6.9: | ||
| title: appleSomeSHA256Hash |
| aggregate_failures do | ||
| expect(instance.oids[:'1.2.840.113635.100.6.1.15'].to_s).to be_a(String) | ||
| expect(instance.oids[:'1.2.840.113635.100.6.1.15'].to_s).to eq 'appleImg4Manifest' | ||
| expect(instance.oids[:'1.2.840.113635.100.6.1.15'].to_s).to eq 'appleImg4ManifestSpecification' |
Comment on lines
+624
to
+626
| title: Model ID | ||
| mlb#: | ||
| title: Main Logic Board Serial |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.