Skip to content

Bye, warehouse!#994

Merged
skyfallwastaken merged 4 commits intomainfrom
bye-warehouse
Feb 23, 2026
Merged

Bye, warehouse!#994
skyfallwastaken merged 4 commits intomainfrom
bye-warehouse

Conversation

@skyfallwastaken
Copy link
Member

It wasn't used for anything (nothing inherited WarehouseRecord) so let's get rid of it entirely.

@skyfallwastaken skyfallwastaken enabled auto-merge (squash) February 23, 2026 20:13
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 23, 2026

Greptile Summary

This PR removes the unused warehouse database configuration and WarehouseRecord model that was intended for Metabase but never actually used.

Key changes:

  • Deleted app/models/warehouse_record.rb (no classes inherited from it)
  • Removed warehouse database config from database.yml (development, test, production)
  • Removed WAREHOUSE_DATABASE_URL from .env.example
  • Changed Docker exposed port from 80 to 3000 with HTTP_PORT env var

Note: The Dockerfile port change appears unrelated to the warehouse removal - it standardizes on port 3000 for Rails development.

Confidence Score: 5/5

  • This PR is safe to merge - it cleanly removes unused infrastructure with no remaining references
  • The warehouse database was completely unused (no models inherited from WarehouseRecord), all references have been thoroughly removed, and the codebase search confirms no lingering dependencies. The only minor issue is outdated documentation in the Dockerfile comment.
  • No files require special attention - all changes are straightforward deletions of unused configuration

Important Files Changed

Filename Overview
app/models/warehouse_record.rb Removed unused WarehouseRecord model that connected to warehouse database
config/database.yml Removed warehouse database configuration from development, test, and production environments
.env.example Removed WAREHOUSE_DATABASE_URL environment variable reference
Dockerfile Changed exposed port from 80 to 3000 and added HTTP_PORT env var

Last reviewed commit: d521a39

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 23, 2026

Additional Comments (1)

Dockerfile
Update port mapping from 80:80 to 3000:3000 to match new EXPOSE directive

Prompt To Fix With AI
This is a comment left during a code review.
Path: Dockerfile
Line: 6

Comment:
Update port mapping from `80:80` to `3000:3000` to match new EXPOSE directive

How can I resolve this? If you propose a fix, please make it concise.

@skyfallwastaken skyfallwastaken merged commit 8c0227c into main Feb 23, 2026
13 checks passed
@skyfallwastaken skyfallwastaken deleted the bye-warehouse branch February 23, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant