-
Notifications
You must be signed in to change notification settings - Fork 444
Add firepad #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firepad #513
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
We think we remembered to add everything, but we might have missed something. |
|
Looks good to me. I approve this PR, My approved PR: #466 |
return-misaPuding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

you should probably correct the branding - 5mm long text on a 3D printed bottom case isn´t really going to be readable, particularly not by sleep deprived dari. the top part of the case also lacks branding. other than that, LGTM! (PR #634 )
I misunderstood the instructions in https://hackpad.hackclub.com/guide#finishing, will tweak the branding |
|
LGTM |
Overlord-Runt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Wait is this not current or did I just like not fix the thing I was told to fix last time by mistake |
|
maybe you didnt update it? |
I thought I fixed it but idk I'll check, once I get into fusion |
|
@Firepup6500 is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
|
this might take a bit - gonna try to pull my repo down locally to make my changes (Less commits), which is probably gonna take a while lol |
|
@Overlord-Runt I think that should fix it? |
Overlord-Runt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm approved. fill out forms.hackclub.com/hackpadv2 to get your hackpad


Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
Check off the following to let the reviewers know you've done everything:
[X] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[X] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[X] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[X] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[X] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[X] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:
If you're unsure about the format, make sure to check out this example and follow the format there.
If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!