-
Notifications
You must be signed in to change notification settings - Fork 444
Segfaultpad submission #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
qcoral
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome job - can you delete the kicad libraries and link to them in a markdown document or something instead? it's extremely big and clogging the repo
…hackpad into segfaultpad-submission
|
Okay, I made the changes in my fork, and I think they updated here too? Let me know if there is anything else, or I did something wrong! Thank you. |
danieliscrazy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! Everything looks great, but you need to brand both the top and bottom case parts. Once you've done that, I'll give you an approval!
|
Okay, thanks! The bottom is branded, but I forgot the top. |
|
@AI314159 it doesn´t look like you updated the stl files for the top case yet...? |
|
Yeah, FreeCAD was being annoying about it, so I'll just remodel it in F360, I haven't gotten to it yet because of schoolwork. |
|
Deployment failed with the following error: |
|
Well, I did the branding, and redid the entire case. Any way you could re-review, @return-misaPuding, @danieliscrazy? Also, I don't know what the error above is, but I am assuming it will be fine because I didn't change anything on the website? I don't really know, I just hope I won't have to do any more work on it, considering my 200 kbps internet. Thank you! |
|
Looks good! |
M0HID
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! You can order your Hackpad here!
Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
Check off the following to let the reviewers know you've done everything:
[X] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[X] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[X] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[X] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[X] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[X] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:
If you're unsure about the format, make sure to check out this example and follow the format there.
If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!