Added my hackpad, nespad-v1 #528
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I approve of this, I just wanted to say that it looks like you made traces for the labeling and art instead of silkscreen, since it doesn't collide with any traces its valid but it'll be harder to see. I approve though. My hackpad pr: #452 |
danieliscrazy
left a comment
danieliscrazy
left a comment
There was a problem hiding this comment.
Hey there! It appears your case is missing branding. All parts of your case must be branded. Once you've fixed this, I'll give you my approval!
|
All done now |
return-misaPuding
left a comment
return-misaPuding
left a comment
There was a problem hiding this comment.
LGTM (PR #634 ), except for the bottom part of the case - over the USB port hole, you left a rim, which will probably need supports to be printed. i´m pretty sure you can remove that rim, since the hole is going to be covered by the top plate anyway
5 participants
Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
Check off the following to let the reviewers know you've done everything:
[/] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[/] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[/] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[/] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[/] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[/] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:
If you're unsure about the format, make sure to check out this example and follow the format there.
If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!