Add JoyKey #604
Add JoyKey #604
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Hey there! Everything looks good, but I noticed a couple things:
- Your case is missing branding. (At least visibly! Please respond with a screenshot if I'm just missing it!)
- You appear to have modified another person's project files. (hackpads/GamePad/pcb/HackPad.kicad_prl)
Once you've fixed this, you'll get my approval!
|
Looks good to me! The case just needs branding before my approval |
|
What?! @danieliscrazy how did I copy the design, I don't see many similarities. Same number of keys as far as I can tell, but the arrangement is different, and mine is much more like a game controller. I have a battery charging circuit and a spot for a 6-axis IMU if I ever wanted it as well. |
|
You didn't copy the design, I'm saying you have a commit that modifies that file for some reason. Please fix that. Also, all case parts need to be branded, not just the top plate. This is to keep track of it at HQ. |
|
Oh! Okay, it was probably modified b/c I had opened it at some point and committed it. Let me add branding to the bottom real quick. |
|
Everything looks good now! This is a really cool design! My PR is #590 |
|
Updated the case, should be ready to go! Also, fairly certain the added ergo grips don't need support and can be bridged with the 3D print. |
There was a problem hiding this comment.
Woah, this is so cool! I love the idea of a gaming controller!
I approve this PR, my approved PR number: #482
|
LGTM!!! Approved fill out this form to get it: |
5 participants
Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
Check off the following to let the reviewers know you've done everything:
[x] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[x] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[x] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[x] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[x] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[x] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:
If you're unsure about the format, make sure to check out this example and follow the format there.
If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!