Merged
Conversation
sampoder
requested changes
May 15, 2025
Member
sampoder
left a comment
There was a problem hiding this comment.
3 things:
- I'd recommend using
unlessinstead ofif ! - This would hide the activity everywhere, including the admin view which is used for auditing / casual auditing, instead we should be editing the
for_eventscope: https://github.com/hackclub/hcb/blob/main/config/initializers/public_activity.rb - Lastly, I don't think we should make this change. I appreciate that people are constantly seeing what has happened most recently and if something weird happens, they're more likely to catch it.
+1 on the idea of an audit log for organisers. not sure where that would belong though.
Contributor
Author
Oh yea those are good points. I found them to be kind of useless without a link to the code but then I also removed them because I thought they were unhelpful at the same time. I think they actually would serve a purpose for casual auditing now with the code easier to find. Before you would have to go digging in transfers to find the user's grant card. I'll make a discussion to track the organizer audit log. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The card grant purchases were cluttering and I don't think were particularly relevant as they weren't by members of the organization. I think there should be a page somewhere for organizers that shows all transactions that have a subledger id set (ex. show all card grant transactions) to better stay on top of them for fraud.