Skip to content

Link to hcb code in public activity#10438

Merged
sampoder merged 2 commits intomainfrom
lro-public-activity-improvements
May 16, 2025
Merged

Link to hcb code in public activity#10438
sampoder merged 2 commits intomainfrom
lro-public-activity-improvements

Conversation

@Luke-Oldenburg
Copy link
Copy Markdown
Contributor

The card grant purchases were cluttering and I don't think were particularly relevant as they weren't by members of the organization. I think there should be a page somewhere for organizers that shows all transactions that have a subledger id set (ex. show all card grant transactions) to better stay on top of them for fraud.

Screenshot From 2025-05-14 22-46-31

@Luke-Oldenburg Luke-Oldenburg requested review from a team as code owners May 15, 2025 02:47
Copy link
Copy Markdown
Member

@sampoder sampoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 things:

  1. I'd recommend using unless instead of if !
  2. This would hide the activity everywhere, including the admin view which is used for auditing / casual auditing, instead we should be editing the for_event scope: https://github.com/hackclub/hcb/blob/main/config/initializers/public_activity.rb
  3. Lastly, I don't think we should make this change. I appreciate that people are constantly seeing what has happened most recently and if something weird happens, they're more likely to catch it.

+1 on the idea of an audit log for organisers. not sure where that would belong though.

@Luke-Oldenburg
Copy link
Copy Markdown
Contributor Author

Luke-Oldenburg commented May 15, 2025

3 things:

1. I'd recommend using `unless` instead of `if !`

2. This would hide the activity everywhere, including the admin view which is used for auditing / casual auditing, instead we should be editing the `for_event` scope: https://github.com/hackclub/hcb/blob/main/config/initializers/public_activity.rb

3. Lastly, I don't think we should make this change. I appreciate that people are constantly seeing what has happened most recently and if something weird happens, they're more likely to catch it.

+1 on the idea of an audit log for organisers. not sure where that would belong though.

Oh yea those are good points. I found them to be kind of useless without a link to the code but then I also removed them because I thought they were unhelpful at the same time. I think they actually would serve a purpose for casual auditing now with the code easier to find. Before you would have to go digging in transfers to find the user's grant card.

I'll make a discussion to track the organizer audit log.

@Luke-Oldenburg Luke-Oldenburg changed the title Ignore card grant purchases and link to hcb code in public activity Link to hcb code in public activity May 15, 2025
@Luke-Oldenburg
Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Member

@sampoder sampoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@sampoder sampoder added this pull request to the merge queue May 16, 2025
Merged via the queue into main with commit 18ce3e4 May 16, 2025
8 checks passed
@sampoder sampoder deleted the lro-public-activity-improvements branch May 16, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants