Add a stats v2 endpoint #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new /api/stats_v2 endpoint with improved field naming and structure for the Flavortown dashboard. The changes rename statistical fields from avg_* to mean_* for consistency and add serialization methods to statistics result classes.
Changes:
- Renamed
avg_hang_time_*fields tomean_hang_time_*throughout the codebase for consistency - Added
as_dict()methods toOverallStatsResultandDailyStatsResultfor API serialization - Created new
/api/stats_v2endpoint with better field names and comprehensive time-period statistics
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| nephthys/api/stats_v2.py | New endpoint implementation providing all-time, daily, and weekly statistics |
| nephthys/utils/stats.py | Renamed fields, added serialization methods, and simplified ticket filtering logic |
| nephthys/api/stats.py | Updated to use renamed mean_* fields |
| nephthys/utils/starlette.py | Registered the new /api/stats_v2 route |
| nephthys/views/home/components/leaderboards.py | Updated references to use renamed fields |
| docs/api.md | Added comprehensive API documentation for the new endpoint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ckclub#152) * Silence type error (that was annoying me) * Add new metric: oldest_unanswered_ticket_age_minutes * Fix datetime subtraction exception
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Flavortown dashboard!
Created a new API endpoint in order to name the fields better and format it a bit nicer.