Conversation
|
@Kapitar is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
|
I don't think it makes sense to change it to a PUT endpoint if it's still only used to toggle viability. The client doesn't even send a request body. Frankly, I think there's no point touching the endpoint until it's turned into an endpoint for updating the entire event. I do like the toast to show the voting status though! |
|
got it! i wanted to change it because you said that "I made this endpoint while I was at MakerHacks in S.F. and I urgently needed to lock voting, needs to be replaced with a real put endpoint" in the slack. i think i got it wrong :( as i understood you wanted an endpoint to update the whole event as a whole instead of just updating one thing in the event? |
|
Yeah, I could have phrased the original message better, sorry! I meant a PUT endpoint to update the entire event. I can always implement it later but if you want to make the change I'll gladly merge it! routers/projects.py contains an update_project endpoint that might be helpful. |
|
got it no problems! since i will make a PUT endpoint to change the event, i also want to make an event edit page |
|
For now, maybe just make an UpdateEvent component (similar to UpdateProject) in a collapsible section on the existing events page. A separate page might eventually be ideal, but I think it's better to maintain the pattern of using collapsible sections until the rest of the project also gets changed. |
|
changed make votable to update the whole event. |
There was a problem hiding this comment.
Resolved my accidental removal of the Airtable API call in d926f35. The commit got made to to the repo instead of this PR.
replaced make-votable POST endpoint with change-votable PUT endpoint