Skip to content

AirHockey#983

Merged
LucasHT22 merged 5 commits into
hackclub:mainfrom
BLADE9078:main
Apr 2, 2023
Merged

AirHockey#983
LucasHT22 merged 5 commits into
hackclub:mainfrom
BLADE9078:main

Conversation

@BLADE9078
Copy link
Copy Markdown
Contributor

@BLADE9078 BLADE9078 commented Mar 22, 2023

Your checklist for this pull request

Author name

Author:

About your game

What is your game about?

How do you play your game?

Code

Check off the items that are true.

  • The game was made using the Sprig editor.
  • The game is placed in the in the /games directory.
  • The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
  • The game runs without errors.
  • The name of the file/game contains only alphanumeric characters, -s, or _s.
  • The game name is not the same as the others from gallery

Image (If an image is used)

Thanks for your PR!

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 22, 2023

@BLADE9078 is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@LucasHT22 LucasHT22 added the submission Game submission label Mar 22, 2023
@LucasHT22
Copy link
Copy Markdown
Member

Thanks for the PR! please answer this:

Author name

Author:

About your game

What is your game about?

How do you play your game?

@BLADE9078
Copy link
Copy Markdown
Contributor Author

BLADE9078 commented Mar 22, 2023 via email

Copy link
Copy Markdown
Member

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, You are from the Thread in Slack, right?

@BLADE9078
Copy link
Copy Markdown
Contributor Author

BLADE9078 commented Mar 22, 2023 via email

@BLADE9078
Copy link
Copy Markdown
Contributor Author

BLADE9078 commented Mar 22, 2023 via email

@LucasHT22
Copy link
Copy Markdown
Member

don't you think it's good to give credits to those who helped you with the game?

@BLADE9078
Copy link
Copy Markdown
Contributor Author

BLADE9078 commented Mar 23, 2023 via email

@LucasHT22
Copy link
Copy Markdown
Member

So add this to code header

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2023 1:29am

@vercel vercel Bot temporarily deployed to Preview – sprig March 24, 2023 16:06 Inactive
@BLADE9078
Copy link
Copy Markdown
Contributor Author

So add this to code header

done!!!

@LucasHT22
Copy link
Copy Markdown
Member

Great! please re-check this:

  • The name of the file/game contains only alphanumeric characters, -s, or _s.

@BLADE9078
Copy link
Copy Markdown
Contributor Author

Great! please re-check this:

  • The name of the file/game contains only alphanumeric characters, -s, or _s.

i didn't get that
can you explain a bit

@LucasHT22
Copy link
Copy Markdown
Member

your game file name must not contain spaces

@BLADE9078
Copy link
Copy Markdown
Contributor Author

BLADE9078 commented Mar 25, 2023 via email

@BLADE9078 BLADE9078 changed the title Air-Hockey AirHockey Mar 25, 2023
@BLADE9078
Copy link
Copy Markdown
Contributor Author

your game file name must not contain spaces

umm.......i think now it's okay

@Tiger-The-Cat
Copy link
Copy Markdown
Contributor

I think Lucas is saying that the actual game file at /games/Air Hockey (1).js, but it should be at /games/AirHockey.js.

@BLADE9078
Copy link
Copy Markdown
Contributor Author

Merge state

so please help me how to change it?

@LucasHT22
Copy link
Copy Markdown
Member

@Tiger-The-Cat it's right, @BLADE9078 where is "Merge state" appearing?

@Tiger-The-Cat
Copy link
Copy Markdown
Contributor

@BLADE9078 In your own sprig fork, go to the /games directory. Then, click on your game file within the games directory. Click the little pencil icon like so:
image
Then, the name of your file that once looked like this:
image
will now look like this:
image
Now, all you have to do is delete the spaces in "Air Hockey (1).js", so it looks like this:
image
Make sure to commit your changes:
image

@BLADE9078
Copy link
Copy Markdown
Contributor Author

BLADE9078 commented Mar 28, 2023 via email

@Tiger-The-Cat
Copy link
Copy Markdown
Contributor

This was all done through my own Sprig fork.

@BLADE9078
Copy link
Copy Markdown
Contributor Author

BLADE9078 commented Mar 28, 2023 via email

@LucasHT22
Copy link
Copy Markdown
Member

@Tiger-The-Cat great tutorial! @BLADE9078 you can follow this tutorial too: https://scribehow.com/embed/How_to_Edit_a_File_on_GitHub_Pull_Request__sdayIETHQ_uIbGVN187mwQ
(I could solve this problem for you but it's a good opportunity for you to learn)

@BLADE9078
Copy link
Copy Markdown
Contributor Author

BLADE9078 commented Mar 28, 2023 via email

@BLADE9078
Copy link
Copy Markdown
Contributor Author

Hey lucas
i'm quite confused with this tutorial
please can you help me out as i am quite excited for submiting my game

@LucasHT22
Copy link
Copy Markdown
Member

what's your doubt?

@BLADE9078
Copy link
Copy Markdown
Contributor Author

BLADE9078 commented Mar 29, 2023 via email

@LucasHT22
Copy link
Copy Markdown
Member

it's a tutorial of mine, just enter the link and then click on Get Started and then next

@ansh3108
Copy link
Copy Markdown
Member

hey @LucasHT22 ! the scribble link you provided above isn't workin....

@LucasHT22
Copy link
Copy Markdown
Member

Sorry! re-check now

Signed-off-by: Soumay Manderna <88175838+BLADE9078@users.noreply.github.com>
@vercel vercel Bot temporarily deployed to Preview – sprig April 1, 2023 09:33 Inactive
@BLADE9078
Copy link
Copy Markdown
Contributor Author

BLADE9078 commented Apr 1, 2023 via email

Signed-off-by: Lucas <88567622+LucasHT22@users.noreply.github.com>
@vercel vercel Bot temporarily deployed to Preview – sprig April 2, 2023 01:29 Inactive
Copy link
Copy Markdown
Member

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Congrats:)
If you're a teen, you can get your sprig here! https://sprig-order.hackclub.dev/

Hack Clubbers would love to see this! Just post a link and 1-2 sentences talking about your game to our #ship channel:)

@LucasHT22 LucasHT22 merged commit 80acaad into hackclub:main Apr 2, 2023
LucasHT22 added a commit that referenced this pull request Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

submission Game submission

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants