fix(comment): move markdown conversion to command layer, add --raw flag#14
Merged
Conversation
- Move md.ToJiraMD() from client to add/edit commands - Add --raw flag to skip markdown conversion - Add omitempty to comment Properties field - Only set properties when internal=true Closes #13
hackerh3
force-pushed
the
hhaecker/fix-comment-markup
branch
from
43374ef to
8b798f6
Compare
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
md.ToJiraMD()conversion from the Jira client layer (pkg/jira/issue.go) up to the command layer (add/editcommands), fixing the bug where comments created via API were double-converted--rawflag tojira issue comment addandjira issue comment editto skip markdown-to-Jira conversion entirely (useful for pre-formatted or programmatic input)omitemptyto thePropertiesfield inCommentBodyso empty properties are not sent to the APIpropertieswheninternal=true, preventing spurious empty objects in API requestsTesting
addandeditcommands verifying--rawflag behaviorpkg/jira/issue_test.goupdated to reflect moved conversion logicCloses #13