generated from hackforla/.github-hackforla-base-repo-template
-
-
Notifications
You must be signed in to change notification settings - Fork 97
Open
Labels
BugEpic/OverviewContains a list of other issues or an overview of issueContains a list of other issues or an overview of issueResearchResearching best approach/solutionsResearching best approach/solutionscomplexity: largedraftNot ready for prioritization yetNot ready for prioritization yetp-feature: Check Inrole: Back Endsize: EpicSize not relevant (epic issue)Size not relevant (epic issue)
Milestone
Description
Overview
Associated check in bug issues:
- Bug: Users Cannot Check In #1411
- [vrms.io] Most meeting times are stuck at "2024-03-xx" - "2024-04-xx" #1795
- The Guides team meeting is not available for checkin #1530
Current overview of Check In Bug per @trillium:
Overview:
- We have accurate timestamps for when the event should start, but the timestamp's date creation is happening sometimes on the day before because of timezone differences between Pacific Time and GMT.
- So, we need to update the backend function to take into account timezone differences of the base timestamp vs. now.
Here's a summary of what happens with events on VRMS:
- A recurring event is generated or updated
- The front end sends a timestamp with the user's selected time to the backend
- The backend stores that timestamp in GMT
- Periodically (weekly) the backend runs a script checking to see if any events happen on a day of the week (e.g., Thursday).
- Within this bucket of events, a new date is generated in today's time and then the hour of that now current timestamp is set to the same hour as the stored recurring event hour.
- Come check in time, a separate script is run to see if any of the events should be considered open (I believe the window is 30 min before start time and 30 min after the end of the event).
- If the event's date is off, due to it being created in the wrong timezone (e.g., GMT vs. PST), then when the hour is assigned, the time is roughly off by 1 day or +/- 1 hour.
Action Items
Need to employ test-driven development to resolve this issue.
- Test timestamps in previous daylight savings period generate correct time today #1839
- (Pending research outcomes from Test timestamps in previous daylight savings period generate correct time today #1839, additional issues will be added here). Where possible, portions of the create recurring events structure should be refactored into smaller functions so that they are more easily testable via unit tests.
- Investigate and Fix Incorrect Event Check-In Times in VRMS #1872
Resources/Instructions
Metadata
Metadata
Assignees
Labels
BugEpic/OverviewContains a list of other issues or an overview of issueContains a list of other issues or an overview of issueResearchResearching best approach/solutionsResearching best approach/solutionscomplexity: largedraftNot ready for prioritization yetNot ready for prioritization yetp-feature: Check Inrole: Back Endsize: EpicSize not relevant (epic issue)Size not relevant (epic issue)
Type
Projects
Status
Epic Issues