Skip to content

Conversation

@bconti123
Copy link
Member

@bconti123 bconti123 commented Jul 31, 2025

Fixes #1640

What changes did you make and why did you make them?

  • I reviewed /src/pages/UserWelcome.jsx and created a similar MUI component for the message "Sorry, the link is not valid anymore".
  • Improve loading screen design to enhance user interaction.
  • Replaced HTML elements with MUI components.
  • Fixed the loading spinner, created a new logic function for loading, and refactored the loading spinner code.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied SorryLink
Visuals after changes are applied AfterSorry

Loading Screen - See this video

VRMS.-.Google.Chrome.2025-07-30.16-48-20.mp4

Refresh the page and see the loading spinner.

VRMS.-.Google.Chrome.2025-08-05.17-33-34.mp4

@bconti123
Copy link
Member Author

This PR is still a work in progress. The loading spinner doesn't appear when the page is refreshed without a valid link.

@bconti123
Copy link
Member Author

I fixed the loading spinner. This PR is now ready for review.

@bconti123
Copy link
Member Author

I double checked the logic function for loading data. I commented Delayed component out then implemented the logic function on between {!isLoaded ?... and ...</Typography> )} in line 75 - 81. PR is now ready.

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!

Would you mind cleaning up the comments that are no longer needed?

Happy to emerge after that! Thanks for your work Byant.

@bconti123
Copy link
Member Author

@trillium Thank you! I cleaned up the comments of Delayed Component. It is no longer needed.

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bryant!

@bconti123 bconti123 merged commit 254529a into hackforla:development Aug 19, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/auth/HandleAuth.jsx

2 participants