Filtering dropdowns on wins page

[jbubar]

Overview

create buttons to filter by Role and Team

Action Items

• [ ]

Resources/Instructions

figma
project page

[akibrhast]

Progress Update

If you look at the gif , you will noticed that the url changes based on the selection.

Need Information (What should the URL look like if the items in the query string have spaces?)

Currently they look like

role=Business%20Analyst,Development,PM&team=VRMS,HackforLA%20Website,Home%20Unite%20Us,311%20Data

But the project filter in the home page does something like this

looking=Business+Analyst&technologies=Code+Climate

The first one is replacing spaces with '%20' the second one is replacing spaces with "+"
Should I follow the second one?

@jbubar

[jbubar]

It is up to you! I noticed the project page uses a '+' also. I am not sure why. I think the %20 makes more sense, otherwise you might get results that you are not looking for.
But at the same time consistency is really important.
I would live to hear your thoughts

[akibrhast]

Based on this and also due to the need of staying consistent. I am thinking we should just use '+' . Also based on really any other sides with query parameters , amazon,facebook,google,youtube ... they all seem to be using '+' for spaces in the query parameter .

[akibrhast]

The following gif demonstrates the changes made in the pull request