Clean up the _data/navigation/main.yml

[jbubar]

Overview

We need to remove the unused icons for our nav bar and standardize the use of quotes in the menu, to close out our updating of the menu from the old format to the new.

Details

• Remove unnecessary lines of code for each of the nav items:
  • Remove the svg's from the repo if they are not used elsewhere on the site
• Identify if we need the single quote for menu items to work. If we don't need any quotes, then remove them. It's possible that we do need the quotes on the items that link to anchors within the site. If we do need them there, then make a recommendation if we should have them only there or on all.
  • revise file to meet approved recommendation
  • revise wiki to have standards info

Resources

Recommendation

standardize the navigation links found on _data/navigation/main.yml to have single quotes.

Example:

- name: Events
  link: '/events'
  list_class_name:   # unnecessary
  icon: /svg/icon-hacknights.svg  # unnecessary

Delete the last two lines

    - name: Events
      link: '/events'
-     list_class_name:
-     icon: /svg/icon-hacknights.svg

Notice that the link has single quotes for the /#about and no quotes for the /toolkit. The second part of this issue is to standardize this.

- name: Connect
 link: '/#about'
 list_class_name:
 icon: /svg/icon-about.svg

- name: Toolkit
 link: /toolkit
 list_class_name:
 icon: /svg/icon-wrench.svg

links to the icons:
_includes/svg/icon-hacknights.svg
_includes/svg/icon-press.svg
_includes/svg/icon-about.svg
_includes/svg/icon-wrench.svg

[ExperimentsInHonesty]

@hisergiorojas Please provide update

1. Progress
2. Blockers
3. Availability
4. ETA

[hisergiorojas]

It's is recommended to use quotes on string with a special character such as '#'

[ltung05]

@drubgrubby please provide a review of the above suggestion and directions for proceeding

[drubgrubby]

@ltung05 I believe this was the page that Sergio's recommendation came from: https://stackoverflow.com/questions/19109912/yaml-do-i-need-quotes-for-strings-in-yaml

It says: Use quotes if your value includes special characters, (e.g. :, {, }, [, ], ,, &, *, #, ?, |, -, <, >, =, !, %, @, ).

Since some of the links on the menu are to specific places on the page, and hence use the '#' character, this would suggest we use quotes.

Additionally, a number of "jekyll cheatsheets" and other resources I looked at such as https://devhints.io/jekyll use single quotes for links.

Therefore:
I recommend we standardize the navigation links found on _data/navigation/main.yml to have single quotes.

Example: link: '/#projects'

[pawan92]

@hisergiorojas standardize the navigation links found on _data/navigation/main.yml to have single quotes.