Skip to content

Add vert 2#1001

Merged
drubgrubby merged 2 commits intohackforla:gh-pagesfrom
mcspach:add-vert-2
Feb 7, 2021
Merged

Add vert 2#1001
drubgrubby merged 2 commits intohackforla:gh-pagesfrom
mcspach:add-vert-2

Conversation

@mcspach
Copy link
Copy Markdown
Member

@mcspach mcspach commented Feb 4, 2021

Addresses issues in #905
-Adds vertical: 'Environment' to metro-on-time project.

This issue is not 100% complete.

@drubgrubby
Copy link
Copy Markdown
Member

@mcspach - The work itself looks good.

A couple of notes on the pull request itself:

  1. The PR title should be descriptive so it's easy to see what it's about when scanning a list. What you named your commit, "add vertical Environment to metro-ontime / railstats", or something like that would be good.
  2. The first line of the PR should refer to the issue that it's addressing. If it completes the issue, it should say "Fixes Add project vertical information to project cards: Environment #905" (or whatever the issue number is). If this text exists the issue will automatically be closed when the PR is merged. If it deals only with a part of an issue, as this does, you can write something like "Addresses issues in Add project vertical information to project cards: Environment #905". This makes it so the person reviewing the issue doesn't have to search through all of the issues to find the one related to this so that they can do the review.

Please make these changes to the PR so that we can merge this. Nice work.

(I usually go over this stuff at the developers' meeting, but I haven't seen you there and don't know if you're able to attend).

@mcspach
Copy link
Copy Markdown
Member Author

mcspach commented Feb 4, 2021

@drubgrubby thank you for the feedback. I should have known better, and I realized that I had forgot to mention the issue number in the request right as I was going to sleep. Will be fixed next time around, and hope to attend the meeting as soon as possible.

@mcspach mcspach linked an issue Feb 4, 2021 that may be closed by this pull request
8 tasks
@drubgrubby drubgrubby merged commit da692f1 into hackforla:gh-pages Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add project vertical information to project cards: Environment

2 participants