Merged
Conversation
Member
|
@mcspach - The work itself looks good. A couple of notes on the pull request itself:
Please make these changes to the PR so that we can merge this. Nice work. (I usually go over this stuff at the developers' meeting, but I haven't seen you there and don't know if you're able to attend). |
Member
Author
|
@drubgrubby thank you for the feedback. I should have known better, and I realized that I had forgot to mention the issue number in the request right as I was going to sleep. Will be fixed next time around, and hope to attend the meeting as soon as possible. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues in #905
-Adds vertical: 'Environment' to metro-on-time project.
This issue is not 100% complete.