Conversation
drubgrubby
left a comment
drubgrubby
left a comment
There was a problem hiding this comment.
The quote itself looks good to me. Perhaps @daniellex0 has a second to do a visual review.
Two things:
- I think that the styles should not go on /elements/_typography.scss unless they're also going to be used on other pages.
@daniellex0 - would we use these same classes on the quote on the main page? Would we use them somewhere else? Do you have an opinion on where these classes should live? (They can always just live on about-us.scss)
- Your changes seem to have impacted the sticky navigation somehow. See the image below, when the page is all the way at the top, before it gets sticky, it has just disappeared. That needs to be corrected...obviously.
|
Just did a visual review, looks great @thatguyish ! 👍 My only minor edit is that the "- Mayor Eric Garcetti" line shouldn't be in itallics- instead if you'll notice in the Figma and in David's screenshot that's on the current page, it's regular straight text but a slightly lighter color (#767676)
And @drubgrubby I agree I don't think it should live on the typography scss file quite yet- at least not until we consolidate with the quote on the homepage when the redesign happens.. so I think let's keep it on about_us.scss for now if possible and I'll think about its reusability |
|
Made the changes necessary for the cite and card. |
|
@thatguyish Great, looks good! 👍 |
|
@daniellex0 thank god cuz if the designer aint happy no one is lol. |
|
@thatguyish @daniellex0 - I guess everyone's happy, then. Nice work! Ready to merge. |
3 participants
fixed #936