Merged
Conversation
erikaBell
approved these changes
May 6, 2021
Member
erikaBell
left a comment
erikaBell
left a comment
There was a problem hiding this comment.
@sena-ji This looks good ~ In future pull requests could you provide "before" and "after" photos of the work you did. It makes it much easier for reviewers to know what they are looking for. Also, friendly reminder to "assign" someone to review your PR once it is created (-:
Thanks!
Member
Author
Sorry, I totally forgot the before and after photos. I will add them to my next PR. Thank you for both of the reminders :). Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1115