Changed iframe object to object video player #6915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Member
|
Reviewing this PR. |
ha-bach
suggested changes
Jun 1, 2024
Member
There was a problem hiding this comment.
Hi @Cloid, great work!
What works:
- Original issue is linked
- Appropriate into and from branches
- Good PR description, visual changes are provided
- Object implementation works well on my Linux laptop
Concerns:
- There is a merge conflict with the current version of the website that needs to be resolved before it can be merged (if you need help with this let me know)
- Video does not fit the screen on mobile view (I tested using Galaxy S20 Ultra on Firefox). Googling 'responsive video object' gets several possible fixes for this issue. Changing object's width to a percentage and change height accordingly seems to work on my end.
Member
|
@Cloid Please resolve the merge conflict and add an availability and ETA for the requested changes. Thanks! |
Member
Author
|
Hi there, sorry for the delay. I'll finish this by EOD Thursday, 08/01 |
Merging branch 'gh-pages' into event-iframe-to-object
Member
Author
|
@muninnhugin Screen sizing is now fixed for all screen sizes, tested via Firefox/Chrome. |
Member
|
Reviewing now, should be done by EOD today. Sorry new schedule, I'm really busy during the week now. |
roslynwythe
approved these changes
Aug 19, 2024
Member
roslynwythe
left a comment
roslynwythe
left a comment
There was a problem hiding this comment.
Great job @Cloid with this challenging issue.
- code is clean and complete
- Pull Request has well-formed branches, screenshots and descriptive text
- This branch checks out in the browser (Chrome) at all screen sizes
Thank you!
This was referenced Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6749
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Before Changes
After Changes