Skip to content

Conversation

@patelbansi3009
Copy link
Member

@patelbansi3009 patelbansi3009 commented Aug 13, 2024

Fixes #7134

What changes did you make?

  • Updated code which starts on Line 825 and ends on Line 855.
  • Edited the example of the pull-request-template.md in the CONTRIBUTING.md file

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/patelbansi3009/website/blob/edits-in-CONTRIBUTING.md-section-3.1.b-7134/CONTRIBUTING.md  

@t-will-gillis t-will-gillis added role: back end/devOps Tasks for back-end developers Feature: Onboarding/Contributing.md Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 1pt Can be done in 4-6 hours labels Aug 14, 2024
@dcotelessa dcotelessa changed the title Edits in CONTRIBUTING.md Section 3.1.b #7134 Edits in CONTRIBUTING.md Section 3.1.b-7134 Aug 14, 2024
@dcotelessa dcotelessa changed the title Edits in CONTRIBUTING.md Section 3.1.b-7134 Edits in CONTRIBUTING.md Section 3.1.b #7134 Aug 14, 2024
@dcotelessa
Copy link
Member

One of the PR checks is failing. Can we describe why this is faling and then fix?
Thanks.
"Set PR Labels / generate-labels-artifact (pull_request) Failing after 8s"

@t-will-gillis t-will-gillis self-requested a review August 14, 2024 16:52
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @patelbansi3009

As @dcotelessa pointed out, there is a failing PR check. This is not because of anything you did, rather it is due to an unintended conflict with the text in the original issue (which I wrote-ugh).*** Please substitute the new text as shown. Otherwise, your branches look good and you are linking the original issue. For "What changes did you make?", I would recommend simplifying this by removing the actual code changes, and instead stating something to the effect of: "Edited the example of the pull-request-template.md in the CONTRIBUTING.md file". Otherwise, looks good!

***FYI the reason that "Set PR Labels" workflow is failing is because the text for the example PR template includes the line ... for example 'Fixes # 9876'. When your PR was created, the bot did a regex search for an issue number appearing after the pattern "Fixes #' and likely found both the correct issue number reference (7134) and the template example (9876). The workflow then crashed when it could not find the example issue nor retrieve its labels. My bad.

@pluto-bell pluto-bell self-requested a review August 15, 2024 19:05
@roslynwythe roslynwythe removed their request for review August 19, 2024 18:36
@patelbansi3009
Copy link
Member Author

patelbansi3009 commented Aug 21, 2024

Hey @dcotelessa and @t-will-gillis , Sorry for the delayed update, Please check the PR and let me know if any updates need to be done. Thank You!

@t-will-gillis t-will-gillis self-requested a review August 21, 2024 01:54
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @patelbansi3009 Thank you for making the change. The automations re-ran when you resubmitted and they all went through.

  • Branches look good
  • There is a link back to the original issue
  • There are concise descriptions of what was done and why
  • The screenshots are good- even though they aren't website changes, I feel like it is appropriate to show the CONTRIBUTING.md
  • The code changes are clean

Thank you for working on this!

@jphamtv
Copy link
Member

jphamtv commented Aug 22, 2024

Hi @dcotelessa and @pluto-bell, Could you please provide your estimated time for review and your availability? Thanks!

@dcotelessa
Copy link
Member

ETA: Thu-Fri: 3:30-5:30pm
Availability: 1 hr.

Copy link
Member

@dcotelessa dcotelessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fixes!

  • The precheck is working now.
  • Branch is named well
  • Link to issue
  • Well written explanations
  • I like the screenshots of the changes just to confirm the differences

Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Onboarding/Contributing.md role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Projects

Development

Successfully merging this pull request may close these issues.

Edits to CONTRIBUTING.md at Pull Requests, Sec 3.1.b

5 participants