-
-
Notifications
You must be signed in to change notification settings - Fork 844
Edits in CONTRIBUTING.md Section 3.1.b #7134 #7279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits in CONTRIBUTING.md Section 3.1.b #7134 #7279
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
|
One of the PR checks is failing. Can we describe why this is faling and then fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @patelbansi3009
As @dcotelessa pointed out, there is a failing PR check. This is not because of anything you did, rather it is due to an unintended conflict with the text in the original issue (which I wrote-ugh).*** Please substitute the new text as shown. Otherwise, your branches look good and you are linking the original issue. For "What changes did you make?", I would recommend simplifying this by removing the actual code changes, and instead stating something to the effect of: "Edited the example of the pull-request-template.md in the CONTRIBUTING.md file". Otherwise, looks good!
***FYI the reason that "Set PR Labels" workflow is failing is because the text for the example PR template includes the line ... for example 'Fixes # 9876'. When your PR was created, the bot did a regex search for an issue number appearing after the pattern "Fixes #' and likely found both the correct issue number reference (7134) and the template example (9876). The workflow then crashed when it could not find the example issue nor retrieve its labels. My bad.
|
Hey @dcotelessa and @t-will-gillis , Sorry for the delayed update, Please check the PR and let me know if any updates need to be done. Thank You! |
t-will-gillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @patelbansi3009 Thank you for making the change. The automations re-ran when you resubmitted and they all went through.
- Branches look good
- There is a link back to the original issue
- There are concise descriptions of what was done and why
- The screenshots are good- even though they aren't website changes, I feel like it is appropriate to show the
CONTRIBUTING.md - The code changes are clean
Thank you for working on this!
|
Hi @dcotelessa and @pluto-bell, Could you please provide your estimated time for review and your availability? Thanks! |
|
ETA: Thu-Fri: 3:30-5:30pm |
dcotelessa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your fixes!
- The precheck is working now.
- Branch is named well
- Link to issue
- Well written explanations
- I like the screenshots of the changes just to confirm the differences
Great job!
Fixes #7134
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)
Visuals before changes are applied
Visuals after changes are applied