Skip to content

Conversation

@aadilahmed
Copy link
Member

Fixes #7193

What changes did you make?

  • Capitalized "Slack" on line 36 of the file .github/ISSUE_TEMPLATE/pre-work-template---dev.md

Why did you make the changes (we will use this info to test)?

  • To make sure that "Slack" is capitalized in the pre-work issue template for developers

For Reviewers

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Screenshot 2024-08-17 at 19-14-35 New Issue · aadilahmed_website

Visuals after changes are applied

Screenshot 2024-08-17 at 19-12-59 New Issue · aadilahmed_website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b aadilahmed-fix-capitalization-slack-prework-template-7193 gh-pages
git pull https://github.com/aadilahmed/website.git fix-capitalization-slack-prework-template-7193

@dcotelessa
Copy link
Member

M-F: Noon-4
ETA: 2hours

@mrodz
Copy link
Member

mrodz commented Aug 18, 2024

Availability: Weekdays 5pm-9pm, Weekends 10am-5pm
ETA: EOD 8/19

Copy link
Member

@mrodz mrodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aadilahmed, great work!

  • Correct to/from branches
  • Correct linked issue number
  • Fair description of your patch and its justification
  • Fixed the issue at hand
  • Made testing the patch easy by changing your fork's default branch and providing an easy URL

I checked out your change, and it looks great. Keep up the good work!

Copy link
Member

@dcotelessa dcotelessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Branches are corrcet
  • issue number is correct
  • Descriptive explanation of fix and reason
  • Tested and works!

Thank you, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Fix Capitalization of "Slack" in Issue Template pre-work-template--dev.md line 37

4 participants