Skip to content

Conversation

@terrencejihoonjung
Copy link
Member

Fixes #7283

What changes did you make?

  • Moved Will Gillis' entry from the current location in the markdown file to the line after Bonnie's entry and any "Role: Product Manager" and/or "Role: Product Team", but before any "Role: Merge Team"

Why did you make the changes (we will use this info to test)?

  • To correctly order the entries for the Hack for LA Website project page.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b terrencejihoonjung-update-project-profile-7283 gh-pages
git pull https://github.com/terrencejihoonjung/website.git update-project-profile-7283

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Aug 22, 2024
Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @terrencejihoonjung, good job working on this issue and writing your PR!

  • Branches are set up correctly
  • Original issue is linked in the PR
  • You explained the changes you made and why
  • Screenshots of the changes are included in the PR
  • The page shows up correctly when testing your branch

Thanks for working on this issue.

@pluto-bell pluto-bell self-requested a review August 26, 2024 21:20
Copy link
Member

@pluto-bell pluto-bell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Branches are setup correctly
  • PR is detailed
  • Code looks good

@codyyjxn codyyjxn requested review from codyyjxn and removed request for codyyjxn August 27, 2024 02:05
@t-will-gillis t-will-gillis merged commit b3bea27 into hackforla:gh-pages Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Website Leadership (Will Gillis)

4 participants