Skip to content

Conversation

@jchue
Copy link
Member

@jchue jchue commented Sep 24, 2024

Fixes #7194

What changes did you make?

  • Capitalized "Slack" in pre-work-template---design.md when used as a proper noun

Why did you make the changes (we will use this info to test)?

  • Correctly capitalize "Slack" when it's used to refer to the app or the company in our code and content.

For Reviewers

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jchue-capitalize-slack-7194 gh-pages
git pull https://github.com/jchue/hackforla-website.git capitalize-slack-7194

Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jchue Thank you for taking on this issue. The branch name is correct and the commits are correct. The link provided is good I was able to see the changes you made. Good Job!

@FamousHero FamousHero self-requested a review September 25, 2024 02:02
Copy link
Member

@FamousHero FamousHero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jchue thanks for taking up this issue!

  • Issue number correctly referenced in branch & PR
  • Descriptive PR title & changes made
  • Why you made the changes is clear
  • Link to updated template works well
  • Followed Action Items to a tee
    Excellent work!! Keep it up!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Fix Capitalization of "Slack" in Issue Template pre-work-template---design.md line 66

4 participants