Update Project Profile - Added Brandon Hu#8343
Merged
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom Sep 28, 2025
Merged
Update Project Profile - Added Brandon Hu#8343t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
Conversation
github-project-automation
bot
moved this to PR Needs review
in P: HfLA Website: Project Board
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
Member
|
Review ETA: by 7 PM |
lastCoyotes
previously approved these changes
Sep 24, 2025
Member
lastCoyotes
left a comment
lastCoyotes
left a comment
There was a problem hiding this comment.
Changes made are to the requirements of the issue.
No other issues to report, so approving this PR!
Visual changes to the site are there, but the images provided are the files changed and not the site, I've included screenshots from the site and the build of this branch as an example:
Screenshots of the website.
Before:
After:
Member
|
Review ETA: 8 PM 9/25/2025 |
myronchen-git
requested changes
Sep 25, 2025
Member
myronchen-git
left a comment
myronchen-git
left a comment
There was a problem hiding this comment.
Done Correctly
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- The pull request title is named properly.
- The explanation on what things were changed is good.
- The CodeQL alerts have been correctly checked off.
- Code changes have been correctly made.
Required Changes
- In the pull request description, the text at the top, before the "Fixes" text, needs to be removed.
- In this pull request's why section, the reason should be related to the changes. In this case, it's why Brandon Hu needs to be added. Usually, you can derive the reason from the issue's Overview. You can also review the instructions for making a pull request to get an idea of what to put.
- In this pull request's screenshot section, the screenshots are supposed to be visual changes that are not shown in the Files changed tab. It should not be screenshots of code. Please review this part of the pull request instructions, view the example gif, and look at other pull requests on what kind of screenshots to use.
- In the issue, the last action item needs to be checked off.
Optional Changes
- You can move Brandon Hu to immediately below Karen Coronel, so that the list is organized by role. I don't remember if there is an official requirement for this, but it would really help visitors.
Other Notes
- I noticed that you requested a review from gmgonzal. If you did this through the right panel, and clicking on one of the suggestions, then it is not recommended that you do this. The suggestions are drawn from all members on the website team, which has many inactive members. A better way to get reviewers is to post a message on the website team's Slack channel or bringing this up in a meeting.
github-project-automation
bot
moved this from PR Needs review
to PRs being reviewed
in P: HfLA Website: Project Board
Member
Author
|
@lastCoyotes Thank you for your insightful comment. I will ensure that I follow the required guidelines optimally. |
Member
Author
|
@myronchen-git Thank you for your insightful comment i have managed to work on the changes needed let me know if all are okay.
Visuals before changes are applied and visual after changes are applied
Visuals after changes are applied
|
myronchen-git
requested changes
Sep 26, 2025
Member
myronchen-git
left a comment
myronchen-git
left a comment
There was a problem hiding this comment.
Thank you for quickly making the changes. Though, one thing was incorrectly done.
Required Changes
- In this pull request's description's screenshot section, the screenshot before changes is supposed to be what the webpage looks like without any changes made. It is not supposed to show Brandon Hu on the webpage yet. Please attach a screenshot without Brandon Hu added.
Member
Author
|
@myronchen-git Visuals before changes are applied and visual after changes are applied
Visuals after changes are applied
|
myronchen-git
approved these changes
Sep 26, 2025
Member
myronchen-git
left a comment
myronchen-git
left a comment
There was a problem hiding this comment.
Well done. Everything seems to be in order.
lastCoyotes
approved these changes
Sep 27, 2025
github-project-automation
bot
moved this from PRs being reviewed
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8112
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Visuals before changes are applied
Visuals after changes are applied