Skip to content

Conversation

@MohamedTwahir
Copy link
Member

@MohamedTwahir MohamedTwahir commented Oct 14, 2025

Fixes #8330

What changes did you make?

  • removed Node.js from the list of technologies

Why did you make the changes (we will use this info to test)?

  • In order to keep project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

image

Visuals after changes are applied

image

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b MohamedTwahir-update-profile-node-8330 gh-pages
git pull https://github.com/MohamedTwahir/website.git update-profile-node-8330

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 14, 2025
@kdaca19xx kdaca19xx self-requested a review October 15, 2025 02:16
@kdaca19xx
Copy link
Member

Availability - after 11am (pacific)
ETA - 10/15

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome effort, MohamedTwahir!

Things Done Well

  • The pull request was done with the correct branch.

  • There's a linked issue. I read/understood it.

  • Your deletion in the Files Changed tab looks good.

  • Using Docker, I can see that "Node.js" has been removed from the Technologies list

Suggestions

  • Please consider paying closer attention to the screenshots you upload to show your hard work. Your "Visuals before changes are applied" screenshot and your "Visuals after changes are applied" screenshot are the same. So, they both show Node.js in the Technologies list as if you didn't edit the Technologies variable in the code. Below is the screenshot I took while in Docker; and below that is a screenshot of what I see under your "Visuals after changes are applied".

I'd like to approve this PR, but it's probably best if you update your "Visuals after changes are applied" before you get an approval. Are you able to change the screenshot under "Visuals after changes are applied"?

MY SCREENSHOT OF YOUR HARD WORK (CAPTURED WHILE IN DOCKER)
image

YOUR SCREENSHOT UNDER "VISUAL AFTER CHANGES ARE APPLIED"
image

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Oct 16, 2025
@MohamedTwahir
Copy link
Member Author

@kdaca19xx
Hi,
The issue required screenshot(visuals)of before and after for both civic tech job's page and the projects card on the project's page. I have made screenshot for both things; civic tech job page and project card. I am guessing what you are seeing is only the project card which appears not to be changing cause I was only required to edit civic-tech-jobs.md file or atleast am guessing thats why the project card isn't changing. Am open to guidance on whether am required to dig deeper for the changes to appear on the project's card too. Let me know if what am saying is clear. I seem to have written an essay lol :)
Regards,
Twahir

Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue.


Done Correctly

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • The pull request title is named properly.
  • The whats and whys in the pull request description have been filled out.
  • The CodeQL alerts have been correctly checked off.
  • Code changes have been correctly made.
  • In the issue, you've correctly assigned yourself and gave your availability and ETA.
  • In the issue, the project and its status has been correctly assigned.

Changes that need to be made

  • As @kdaca19xx mentioned, the screenshot for the projects webpage is the same for before and after changes are made. It looks like you captured the wrong local instance of the HackforLA website. Please upload a new screenshot for after changes are made.

    Both the general projects webpage and the Civic Tech Jobs webpage uses the same markdown file for information. For an example that civic-tech-jobs.md file changes both webpages, see this pull request.

@MohamedTwahir
Copy link
Member Author

@myronchen-git @kdaca19xx
I have updated the required changes let me know if anything else is needed.
Thank you very much.
Availability 7pm - 9pm (GMT 5)

Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the corrections. I don't see anything else out of place.

@kdaca19xx
Copy link
Member

@myronchen-git @kdaca19xx I have updated the required changes let me know if anything else is needed. Thank you very much. Availability 7pm - 9pm (GMT 5)

Thanks again, Mohamed. I'll change my review's status to "approved".

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, MohamedTwahir!

Things Done Well

The pull request was done with the correct branch.

There's a linked issue. I read/understood it.

Your deletion in the Files Changed tab looks good.

Using Docker, I can see that "Node.js" has been removed from the Technologies list.

You uploaded a new screenshot under "Visuals after changes are applied" to show your hard work!

Suggestions

none.

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Oct 17, 2025
@DDVVPP DDVVPP merged commit a8386d0 into hackforla:gh-pages Oct 18, 2025
18 checks passed
@MohamedTwahir MohamedTwahir deleted the update-profile-node-8330 branch October 18, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs (Remove Tech: Node.JS)

4 participants